New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated C#/.NET compatibility tables. (DOCS-11023) #424
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because the compatibility tables are weird, you also need to update the tables in/drivers/driver-compatibility-reference
, which contain all of the driver versions, not just the ones we talk about these days.
@schmalliso , good catch! Staging is updated and ready for another look. |
source/drivers/csharp.txt
Outdated
@@ -127,6 +134,12 @@ MongoDB Compatibility | |||
- .NET 4.5 | |||
- .NET Core | |||
|
|||
* - Version 2.4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This isn't appearing on staging, currently -- not sure why. Assuming it does build correctly, LGTM!
One comment - LGTM assuming it all builds correctly! |
@jyemin , this small update is ready for a technical review. |
After discussing with @rstam, we decided it would be good to explicitly mention all the versions of .NET Core, as we do with .NET Framework. So the table would look like:
|
@jyemin , staging is updated and ready for another look. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One small change to the table.
Also noticed in the rendered view that the second table, now that it has six columns, is cut off on the right no matter how wide my Chrome window is, and I have to horizontally scroll to see the full text of the rightmost header.
source/drivers/csharp.txt
Outdated
@@ -125,37 +132,57 @@ MongoDB Compatibility | |||
- .NET 3.5 | |||
- .NET 4.0 | |||
- .NET 4.5 | |||
- .NET Core | |||
- .NET Core 1.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Re-order so that 1.0 is before 1.1
@jyemin , staging is updated and ready for another look. |
Review by Allison. (DOCS-11023) Added columns for .NET Core 1.0, 1.1, 1.2 to C#/.NET Compatibility tables. (DOCS-11023) Review by Jeff Yemin. (DOCS-11023)
e12746e
to
d16503c
Compare
@kay-kim , this is ready for merge into 3.6 and master. |
Staged at https://docs-mongodbcom-staging.corp.mongodb.com/ecosystem/robertjustice/DOCS-11023/drivers/csharp.html.