(DOCSP-14569): mixed data type #1057
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* new data types for node * added data types to TOC Co-authored-by: Mohammad Hunan Chughtai <mohammad.hunan@mongodb.com>
dacharyc
approved these changes
May 10, 2021
examples/node/Examples/data-types.js
Outdated
| // :code-block-end: | ||
|
|
||
| // :code-block-start: query-objects-with-mixed-values | ||
| // query for Blaise's birthDate by filtering for his name to get the entire Realm object and using dot notation to get the birthDate |
There was a problem hiding this comment.
Nit: this comment read a bit awkward to me (and also ran off the side of the code block and I had to scroll for it). Maybe break it into two lines, and reword it slightly? Maybe something like:
// To query for Blaise's birthDate, filter for his name to retrieve the realm object.
// Use dot notation to access the birthDate property.
There was a problem hiding this comment.
Good idea, done 👍
kneth
approved these changes
May 10, 2021
source/examples/generated/node/data-types.codeblock.query-objects-with-mixed-values.js
Outdated
Show resolved
Hide resolved
added 2 commits
May 11, 2021 11:22
mohammadhunan-dev
pushed a commit
that referenced
this pull request
May 11, 2021
This reverts commit d8fec46.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Info
Jira
Staged Changes (Requires MongoDB Corp SSO)
Review Guidelines
REVIEWING.md
Note - change package.json version to 10.5.0-beta.1 before merging