Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(DOCSP-14569): mixed data type #1057

Merged

Conversation

mohammadhunan-dev
Copy link
Contributor

@mohammadhunan-dev mohammadhunan-dev commented May 10, 2021

Pull Request Info

Jira

Staged Changes (Requires MongoDB Corp SSO)

Review Guidelines

REVIEWING.md

Note - change package.json version to 10.5.0-beta.1 before merging

Mohammad Hunan Chughtai and others added 7 commits May 5, 2021 20:55
Copy link
Collaborator

@dacharyc dacharyc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Love the mathematical doggos.

// :code-block-end:

// :code-block-start: query-objects-with-mixed-values
// query for Blaise's birthDate by filtering for his name to get the entire Realm object and using dot notation to get the birthDate
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: this comment read a bit awkward to me (and also ran off the side of the code block and I had to scroll for it). Maybe break it into two lines, and reword it slightly? Maybe something like:

// To query for Blaise's birthDate, filter for his name to retrieve the realm object.
// Use dot notation to access the birthDate property.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea, done 👍

@mohammadhunan-dev mohammadhunan-dev merged commit d8fec46 into mongodb:master May 11, 2021
mohammadhunan-dev pushed a commit that referenced this pull request May 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants