Skip to content
This repository has been archived by the owner on Mar 5, 2024. It is now read-only.

DOCSP-7502: Update version dropdown button #344

Merged
merged 4 commits into from
Dec 16, 2019
Merged

DOCSP-7502: Update version dropdown button #344

merged 4 commits into from
Dec 16, 2019

Conversation

sophstad
Copy link
Member

@sophstad sophstad commented Dec 12, 2019

[JIRA] [Charts Staging] [BI Connector Staging] Update version dropdown button to be more visible. This change is reflected on all properties that use the standard sidebar dropdown (hence lots of files changed).

image

image

@sophstad sophstad requested a review from i80and December 16, 2019 15:29
Copy link
Contributor

@i80and i80and left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One remark, but otherwise lgtm

width: calc(100% - 34px);
}

.version-sidebar .dropdown-menu {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I might prefer a child combinator rather than the descendant combinator if that works here

@sophstad sophstad changed the title Update version dropdown button DOCSP-7502: Update version dropdown button Dec 16, 2019
Copy link
Collaborator

@allisonmui9 allisonmui9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! Thank you so much Sophie!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
3 participants