Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update GNUmakefile #109

Merged
merged 2 commits into from Jul 9, 2020
Merged

Update GNUmakefile #109

merged 2 commits into from Jul 9, 2020

Conversation

gssbzn
Copy link
Collaborator

@gssbzn gssbzn commented Jul 8, 2020 •
edited

Description

Add goimports to fmt
Add a command to auto fix some linting issues
Add githook precommit

Type of change:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Required Checklist:

  • I have signed the MongoDB CLA
  • I have added tests that prove my fix is effective or that my feature works
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code

@gssbzn
Update GNUmakefile
6c1caac 
Add goimports to fmt
Add a command to auto fix some linting issues
robcarlan-mlab
robcarlan-mlab previously approved these changes Jul 8, 2020
View reviewed changes
Copy link
Contributor

@robcarlan-mlab robcarlan-mlab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@gssbzn gssbzn requested a review from themantissa July 8, 2020 17:56
themantissa
themantissa approved these changes Jul 8, 2020
View reviewed changes
Copy link
Collaborator

@themantissa themantissa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, will add DoU and request quick look.

PacoDw
PacoDw approved these changes Jul 9, 2020
View reviewed changes
Copy link
Contributor

@PacoDw PacoDw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gssbzn gssbzn merged commit 050d3be into master Jul 9, 2020
@gssbzn gssbzn deleted the improve-makefile branch July 9, 2020 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@themantissa themantissa themantissa approved these changes

@PacoDw PacoDw PacoDw approved these changes

@robcarlan-mlab robcarlan-mlab robcarlan-mlab approved these changes

@coderGo93 coderGo93 Awaiting requested review from coderGo93

@gmlp gmlp Awaiting requested review from gmlp

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@gssbzn @themantissa @PacoDw @robcarlan-mlab