Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove libraryVersion from user agent #113

Merged
merged 1 commit into from Jul 16, 2020
Merged

Remove libraryVersion from user agent #113

merged 1 commit into from Jul 16, 2020

Conversation

gssbzn
Copy link
Collaborator

@gssbzn gssbzn commented Jul 14, 2020

Description

The lib version is really out of date, instead of us trying to remember to update it on anew tag is better to just remove it

Type of change:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Required Checklist:

  • I have signed the MongoDB CLA
  • I have added tests that prove my fix is effective or that my feature works
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code

Further comments

@gssbzn gssbzn requested a review from themantissa July 15, 2020 09:49
@gssbzn
Copy link
Collaborator Author

gssbzn commented Jul 15, 2020

@themantissa for you to consider

themantissa
themantissa approved these changes Jul 15, 2020
View reviewed changes
Copy link
Collaborator

@themantissa themantissa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, adding DoU devs for quick check.

coderGo93
coderGo93 approved these changes Jul 16, 2020
View reviewed changes
Copy link
Contributor

@coderGo93 coderGo93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gssbzn gssbzn merged commit c140614 into master Jul 16, 2020
@gssbzn gssbzn deleted the remove-version-from-agent branch July 16, 2020 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@themantissa themantissa themantissa approved these changes

@coderGo93 coderGo93 coderGo93 approved these changes

@robcarlan-mlab robcarlan-mlab robcarlan-mlab approved these changes

@PacoDw PacoDw Awaiting requested review from PacoDw

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@gssbzn @themantissa @coderGo93 @robcarlan-mlab