Add a hook to ensure the client's version is updated before pushing a tag/release #115
Conversation
There was a problem hiding this comment.
LGTM @themantissa ready for you, it would be a good idea if we defined a release procedure to make sure we update the version on tag
There was a problem hiding this comment.
LGTM, @gssbzn a very good point on a documented release process. Thus far we've simply released when we needed a new version for Terraform (or other work) but with all the new dependencies I think it's a very smart suggestion to formalize this. Do you have an example we can follow?
Also adding DoU for review.
|
in mcli we have a RELEASING.md. We also have a little bash script to automate some of the process, we could look if making a bash script to update the version and tag the release would make sense here |
|
@gssbzn this is an excellent example, thank you! Sounds like we'll want similar for this but perhaps figure out communication channels between teams for timing, etc. |
| run: make tools lint test | ||
|
|
||
| - name: Checking the version | ||
| run: make check-version |
There was a problem hiding this comment.
This workflow will ensure that we get notified when a tag was pushed and the version was not updated.
| @@ -13,26 +13,36 @@ link-git-hooks: | |||
| find .git/hooks -type l -exec rm {} \; | |||
| find githooks -type f -exec ln -sf ../../{} .git/hooks/ \; | |||
|
|
|||
| .PHONY: build | |||
There was a problem hiding this comment.
updated for consistency
Description
Link to any related issue(s):
Type of change:
Required Checklist:
make fmtand formatted my codeFurther comments