Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLOUDP-70872: Adding Third-Party Integration Settings #131

Merged
merged 5 commits into from Sep 3, 2020
Merged

CLOUDP-70872: Adding Third-Party Integration Settings #131

merged 5 commits into from Sep 3, 2020

Conversation

andreaangiolillo
Copy link
Collaborator

@andreaangiolillo andreaangiolillo commented Sep 2, 2020 •
edited

Description

Implemented Third-Party Integration Settings

Type of change:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Required Checklist:

  • I have signed the MongoDB CLA
  • I have added tests that prove my fix is effective or that my feature works
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code

Further comments

@andreaangiolillo andreaangiolillo changed the title CLOUDP-70872: Adding api call Create a Configuration for a Third-Party Service Integration to the atlas go CLOUDP-70872: Adding Third-Party Integration Settings Sep 2, 2020
colm-quinn
colm-quinn previously approved these changes Sep 2, 2020
View reviewed changes
Copy link
Collaborator

@colm-quinn colm-quinn left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, though I don't have a lot of context on the API you're using here.

gssbzn
gssbzn requested changes Sep 2, 2020
View reviewed changes
Copy link
Collaborator

@gssbzn gssbzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a couple of small nits

mongodbatlas/third_party_integration.go Outdated Show resolved Hide resolved
mongodbatlas/third_party_integration.go Outdated Show resolved Hide resolved
mongodbatlas/third_party_integration.go Outdated Show resolved Hide resolved
mongodbatlas/third_party_integration.go Outdated Show resolved Hide resolved
mongodbatlas/third_party_integration.go Outdated Show resolved Hide resolved
gssbzn
gssbzn approved these changes Sep 2, 2020
View reviewed changes
Copy link
Collaborator

@gssbzn gssbzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, @themantissa

themantissa
themantissa approved these changes Sep 2, 2020
View reviewed changes
Copy link
Collaborator

@themantissa themantissa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, We'll be using this for Terraform too pretty so let's have one of the devs give it a quick look. Will add

leofigy
leofigy approved these changes Sep 2, 2020
View reviewed changes
Copy link
Contributor

@leofigy leofigy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@andreaangiolillo andreaangiolillo merged commit 049d077 into master Sep 3, 2020
@gssbzn gssbzn deleted the CLOUDP-70872 branch September 15, 2020 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gssbzn gssbzn gssbzn approved these changes

@themantissa themantissa themantissa approved these changes

@leofigy leofigy leofigy approved these changes

@colm-quinn colm-quinn colm-quinn left review comments

@coderGo93 coderGo93 Awaiting requested review from coderGo93

@marinsalinas marinsalinas Awaiting requested review from marinsalinas

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@andreaangiolillo @gssbzn @colm-quinn @themantissa @leofigy