add OrganizationsListOptions for filtering organization list results

[sunny-b]

Description

Addresses #143

The Ops Manager and Atlas API supports filtering Organization list results by the name, however this Go client does not support that at the moment. This PR would add that functionality and adds a test to help ensure it works.

I recognize this is a breaking change to the interface so I'm open to discussion on a better way to do it. Though I saw this pattern in ContainersListOptions which is where I adopted it from.

go-client-mongodb-atlas/mongodbatlas/containers.go

Lines 30 to 33 in d1f10b2

	type ContainersListOptions struct {
	ProviderName string `url:"providerName,omitempty"`
	ListOptions
	}

Link to any related issue(s):

Type of change:

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update

Required Checklist:

• I have signed the MongoDB CLA
• I have added tests that prove my fix is effective or that my feature works
• I have added any necessary documentation (if appropriate)
• I have run make fmt and formatted my code

Further comments

[gssbzn]

Hi @sunny-b, thanks for your contribution, I'm happy to break the client to fix this, just one small comment in case you want to improve OM support as well.
I'll let @themantissa have final say on this breaking change

[gssbzn]

Since you mention Ops Manager, Ops manager also has a boolean, includeDeletedOrgs, I've been wanting to fix this Listing option to add that one in particular but since we are breaking this I wouldn't mind taking the extra step here.
If you decide to add it be aware that it defaults to true so omitempty may get tricky

[sunny-b]

I think using a bool pointer can help get around the omitempty business. According to the docs, if the includeDeletedOrgs param is missing in the url, then it'll still default to true.

I added in that change and made a test to show that setListOptions will properly omit an empty bool pointer. Please let me know if you need anything else for this PR.

[gssbzn]

thanks for adding this, yes, making it a pointer should work

[themantissa]

LGTM as I don't think this impacts us particularly. However added the DoU devs for a quick review to check just in case. FYI @coderGo93 and @leofigy Thanks all!

[sunny-b]

Anyway of getting the appropriate reviews for this? I would love for this feature to get merged in. We're planning on using this Go client at work and this is a much needed feature for us.

[leofigy]

LGTM 👍🏽

[gssbzn]

@sunny-b feel free to add update https://github.com/mongodb/go-client-mongodb-ops-manager with this change as well, we may be doing this anyway in the coming days

[sunny-b]

@gssbzn Yeah that's a good idea. Though you'd need to put out a new release of this package in order to update Ops Manager as it uses the various ListOptions from this package.

[gssbzn]

@sunny-b on the ops-manager-client we usually update to master (go get -u go.mongodb.org/atlas@master), not ideal but we are ok with it since we manage both packages. releasing a new version for the atlas client takes a bit more time as we coordinate this with the team in charge of the terraform provider. Don't feel any pressure on doing this, we'll address this on our next update of the ops manager client dependency for atlas but I can't promise any dates right

[sunny-b]

@gssbzn mongodb/go-client-mongodb-ops-manager#59