Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

INTMDB-144: deleted omitempty for scopes of database users #162

Merged
merged 1 commit into from Dec 21, 2020

Conversation

coderGo93
Copy link
Contributor

Description

Delete the omitempty for scopes parameter so it can send an empty array of scopes in json request.

Link to any related issue(s):

Type of change:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Required Checklist:

  • I have signed the MongoDB CLA
  • I have added tests that prove my fix is effective or that my feature works
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code

Further comments

Copy link
Collaborator

@themantissa themantissa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - knocking this one out since it's a small fix. @gssbzn by since I think only @andreaangiolillo will be in next week I'm going to add him as a reviewer as I just like to have a check on each side as we have more use of the client. Let me know if any issue there. Thanks!

Copy link
Collaborator

@andreaangiolillo andreaangiolillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@themantissa themantissa merged commit dc53924 into master Dec 21, 2020
@themantissa themantissa deleted the INTMDB-144 branch December 21, 2020 15:34
@themantissa
Copy link
Collaborator

@marinsalinas with two approvals I merged but noted I didn't have a 2nd DoU review. Can you just double check this for us? Thanks!

Copy link
Contributor

@marinsalinas marinsalinas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants