Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLOUDP-80413: [go-client] add service to get default mongodb major version #167

Merged
merged 1 commit into from Jan 14, 2021
Merged

CLOUDP-80413: [go-client] add service to get default mongodb major version #167

merged 1 commit into from Jan 14, 2021

Conversation

gssbzn
Copy link
Collaborator

@gssbzn gssbzn commented Jan 14, 2021

Description

Type of change:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Required Checklist:

  • I have signed the MongoDB CLA
  • I have added tests that prove my fix is effective or that my feature works
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code

Further comments

andreaangiolillo
andreaangiolillo approved these changes Jan 14, 2021
View reviewed changes
Copy link
Collaborator

@andreaangiolillo andreaangiolillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

themantissa
themantissa approved these changes Jan 14, 2021
View reviewed changes
Copy link
Collaborator

@themantissa themantissa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Will share w/ the DoU team in slack as an FYI. Don't think we need a review on that side but nice to know we have it, in case we need.

@gssbzn gssbzn merged commit a16df5f into master Jan 14, 2021
@gssbzn gssbzn deleted the CLOUDP-80413 branch January 14, 2021 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@themantissa themantissa themantissa approved these changes

@andreaangiolillo andreaangiolillo andreaangiolillo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@gssbzn @themantissa @andreaangiolillo