Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix username path escape for db username #199

Merged
merged 1 commit into from Apr 12, 2021
Merged

fix: fix username path escape for db username #199

merged 1 commit into from Apr 12, 2021

Conversation

gssbzn
Copy link
Collaborator

@gssbzn gssbzn commented Apr 12, 2021

Description

Link to any related issue(s): #189

Type of change:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Required Checklist:

  • I have signed the MongoDB CLA
  • I have added tests that prove my fix is effective or that my feature works
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code

Further comments

colm-quinn
colm-quinn approved these changes Apr 12, 2021
View reviewed changes
Copy link
Collaborator

@colm-quinn colm-quinn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gssbzn gssbzn requested a review from themantissa April 12, 2021 14:46
@gssbzn
Copy link
Collaborator Author

gssbzn commented Apr 12, 2021

@themantissa ready for you

themantissa
themantissa approved these changes Apr 12, 2021
View reviewed changes
Copy link
Collaborator

@themantissa themantissa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just FYI @leofigy @pitakill and @coderGo93

@gssbzn gssbzn merged commit d1a3b5b into master Apr 12, 2021
@gssbzn gssbzn deleted the fix-path-escape branch April 12, 2021 21:10
@gssbzn gssbzn mentioned this pull request Apr 13, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@colm-quinn colm-quinn colm-quinn approved these changes

@themantissa themantissa themantissa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@gssbzn @colm-quinn @themantissa