Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: remove project whitelist #206

Merged
merged 1 commit into from Jun 2, 2021
Merged

feat: remove project whitelist #206

merged 1 commit into from Jun 2, 2021

Conversation

gssbzn
Copy link
Collaborator

@gssbzn gssbzn commented May 27, 2021

Description

These endpoints will be removed next week so removing the code here

Type of change:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Required Checklist:

  • I have signed the MongoDB CLA
  • I have added tests that prove my fix is effective or that my feature works
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code

@gssbzn gssbzn added the breaking Pull requests that breaks backwards compatibility label May 27, 2021
@gssbzn gssbzn requested a review from a team as a code owner May 27, 2021 10:57
@gssbzn gssbzn requested review from threebee and removed request for a team May 27, 2021 10:57
andreaangiolillo
andreaangiolillo approved these changes May 27, 2021
View reviewed changes
Copy link
Collaborator

@andreaangiolillo andreaangiolillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gssbzn gssbzn requested a review from themantissa May 27, 2021 11:23
@gssbzn
Copy link
Collaborator Author

gssbzn commented May 27, 2021

@themantissa not sure if terraform hasn't updated yet but this change will make it urgent for people to update

@leofigy
Copy link
Contributor

leofigy commented May 27, 2021

AFAIK Not yet :)

@themantissa
Copy link
Collaborator

Yup, we will be deprecating this in the next Terraform version (will create the ticket soon) but we missed our timing as Atlas is actually turning off this endpoints in June (pretty soon). So that will force the change too for new and old downstream tools.

themantissa
themantissa approved these changes Jun 2, 2021
View reviewed changes
Copy link
Collaborator

@themantissa themantissa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@themantissa themantissa requested a review from leofigy June 2, 2021 16:43
@gssbzn gssbzn merged commit 11adad6 into master Jun 2, 2021
@gssbzn gssbzn deleted the remove-project-whitelist branch June 2, 2021 17:37
@themantissa
Copy link
Collaborator

INTMDB-212 for Terraform

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@themantissa themantissa themantissa approved these changes

@andreaangiolillo andreaangiolillo andreaangiolillo approved these changes

@threebee threebee Awaiting requested review from threebee

@leofigy leofigy Awaiting requested review from leofigy

Assignees
No one assigned
Labels
breaking Pull requests that breaks backwards compatibility
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@gssbzn @leofigy @themantissa @andreaangiolillo