Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

INTMDB-19: Added fields in datalake databases and stores #209

Merged
merged 2 commits into from Jun 4, 2021
Merged

INTMDB-19: Added fields in datalake databases and stores #209

merged 2 commits into from Jun 4, 2021

Conversation

coderGo93
Copy link
Contributor

Description

  • Added field AdditionalStorageClasses for DataLakeStore
  • Added field MaxWildcardCollections for DataLakeDatabase

Link to any related issue(s):

Type of change:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Required Checklist:

  • I have signed the MongoDB CLA
  • I have added tests that prove my fix is effective or that my feature works
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code

Further comments

@coderGo93 coderGo93 self-assigned this Jun 3, 2021
@coderGo93 coderGo93 requested a review from a team as a code owner June 3, 2021 23:45
@coderGo93 coderGo93 changed the title INTMDB-19: Added parameter in datalake databases and stores INTMDB-19: Added fields in datalake databases and stores Jun 3, 2021
gssbzn
gssbzn previously approved these changes Jun 4, 2021
View reviewed changes
Copy link
Collaborator

@gssbzn gssbzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but I'm not seeing these fields on our docs assuming they are just undocumented

@coderGo93
Copy link
Contributor Author

Hi @gssbzn , the docs comes from here

@gssbzn
Copy link
Collaborator

gssbzn commented Jun 4, 2021

Hi @gssbzn , the docs comes from here

oh I didn't know that one, can you please add a link to that docs on the field?

@coderGo93 coderGo93 requested a review from gssbzn June 4, 2021 18:24
gssbzn
gssbzn approved these changes Jun 4, 2021
View reviewed changes
Copy link
Collaborator

@gssbzn gssbzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 💯

abner-dou
abner-dou approved these changes Jun 4, 2021
View reviewed changes
Copy link
Contributor

@abner-dou abner-dou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@coderGo93 coderGo93 merged commit 3f489d7 into master Jun 4, 2021
@coderGo93 coderGo93 deleted the INTMDB-19 branch June 4, 2021 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gssbzn gssbzn gssbzn approved these changes

@abner-dou abner-dou abner-dou approved these changes

@themantissa themantissa Awaiting requested review from themantissa

@leofigy leofigy Awaiting requested review from leofigy

Assignees

@coderGo93 coderGo93

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@coderGo93 @gssbzn @abner-dou