Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

INTMDB-145: Support delete function for Cloud Backup Schedules #210

Merged
merged 1 commit into from Jun 17, 2021
Merged

INTMDB-145: Support delete function for Cloud Backup Schedules #210

merged 1 commit into from Jun 17, 2021

Conversation

coderGo93
Copy link
Contributor

Description

Added a function and its test for Delete Cloud Backup Schedules

Link to any related issue(s):

Type of change:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Required Checklist:

  • I have signed the MongoDB CLA
  • I have added tests that prove my fix is effective or that my feature works
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code

Further comments

@coderGo93 coderGo93 self-assigned this Jun 11, 2021
@coderGo93 coderGo93 requested a review from a team as a code owner June 11, 2021 20:55
@coderGo93 coderGo93 mentioned this pull request Jun 12, 2021
Merged
10 tasks
@coderGo93 coderGo93 changed the title INTMDB-145: Added delete function for Cloud Backup Schedules INTMDB-145: Support delete function for Cloud Backup Schedules Jun 12, 2021
gssbzn
gssbzn approved these changes Jun 12, 2021
View reviewed changes
Copy link
Collaborator

@gssbzn gssbzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

andreaangiolillo
andreaangiolillo approved these changes Jun 14, 2021
View reviewed changes
Copy link
Collaborator

@andreaangiolillo andreaangiolillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

themantissa
themantissa approved these changes Jun 14, 2021
View reviewed changes
Copy link
Collaborator

@themantissa themantissa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

abner-dou
abner-dou approved these changes Jun 14, 2021
View reviewed changes
Copy link
Contributor

@abner-dou abner-dou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@coderGo93 coderGo93 merged commit d91c80f into master Jun 17, 2021
@coderGo93 coderGo93 deleted the INTMDB-145 branch June 17, 2021 01:24
@andreaangiolillo andreaangiolillo mentioned this pull request Jun 17, 2021
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gssbzn gssbzn gssbzn approved these changes

@themantissa themantissa themantissa approved these changes

@andreaangiolillo andreaangiolillo andreaangiolillo approved these changes

@abner-dou abner-dou abner-dou approved these changes

@thetonymaster thetonymaster Awaiting requested review from thetonymaster

Assignees

@coderGo93 coderGo93

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@coderGo93 @gssbzn @themantissa @andreaangiolillo @abner-dou