Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update README #220

Merged
merged 3 commits into from Jun 22, 2021
Merged

docs: update README #220

merged 3 commits into from Jun 22, 2021

Conversation

gssbzn
Copy link
Collaborator

@gssbzn gssbzn commented Jun 22, 2021

Description

Small README updates

@gssbzn gssbzn requested a review from a team as a code owner June 22, 2021 08:45
@gssbzn gssbzn requested review from foesa and removed request for a team June 22, 2021 08:45
@@ -54,7 +54,7 @@ func main() {
}

client := mongodbatlas.NewClient(tc)
orgs, _, err := client.Projects.GetAllProjects(context.Background(), nil)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

README.md Outdated
@@ -64,7 +64,7 @@ almost never be shared between different users.

## Versioning

Each version of the client is tagged and the version is updated accordingly.
Each version of the client is tagged, and the version is updated accordingly.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't believe there is a comma before and unless it's a list

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not me, I reverted but FYI this where it came from

Screenshot 2021-06-22 at 16 01 17

@gssbzn gssbzn requested a review from colm-quinn June 22, 2021 15:02
Copy link
Collaborator

@colm-quinn colm-quinn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gssbzn gssbzn merged commit c08b0c0 into master Jun 22, 2021
@gssbzn gssbzn deleted the update-readme branch June 22, 2021 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants