INTMDB-17: Update search #223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 23, 2021 00:59
gssbzn
reviewed
Jun 23, 2021
| @@ -281,7 +283,8 @@ type IndexField struct { | |||
| // SearchAnalyzer custom analyzer definition. | |||
| type SearchAnalyzer struct { | |||
| BaseAnalyzer string `json:"baseAnalyzer"` | |||
| MaxTokenLength *float64 `json:"maxTokenLength,omitempty"` | |||
| MaxTokenLength *int `json:"maxTokenLength,omitempty"` | |||
There was a problem hiding this comment.
any reason for this change? it would be better if we don't but not a blocker
There was a problem hiding this comment.
According to the API documentation for search kndexes and analyzers, this property is an int type.
And that makes more sense (how you can limit a token using a float value?)
What do you think?
There was a problem hiding this comment.
not a blocker like I said but it's a breaking change so trying to avoid it if we can, since for json all number fields are technically float, the previous implementation was valid (even if wrong) but feel free to merge
There was a problem hiding this comment.
ok, It's good to know, so this time I'll merge that change
Thanks for your comment Gustavo
themantissa
approved these changes
Jun 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added properties to search index and search analyzer struct in order to complain with the current mongodb atlas API documentation
Link to any related issue(s):
Type of change:
Required Checklist:
make fmtand formatted my codeFurther comments