Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added custom analyzer structs #224

Merged
merged 2 commits into from Jun 29, 2021
Merged

added custom analyzer structs #224

merged 2 commits into from Jun 29, 2021

Conversation

abner-dou
Copy link
Contributor

Description

Added structs to manage custom analyzers in index struct, also documentation was added to code

Link to any related issue(s):
INTMDB-17

Type of change:

  • Bug fix (non-breaking change which fixes an issue)
  • [ x] New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Required Checklist:

  • I have signed the MongoDB CLA
  • I have added tests that prove my fix is effective or that my feature works
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code

Further comments

@abner-dou abner-dou requested a review from a team as a code owner June 24, 2021 02:37
@abner-dou abner-dou requested review from foesa and removed request for a team June 24, 2021 02:37
gssbzn
gssbzn reviewed Jun 24, 2021
View reviewed changes
mongodbatlas/search.go
@@ -280,7 +280,7 @@ type IndexField struct {
IndexShapes *bool `json:"indexShapes,omitempty"`
}

// SearchAnalyzer custom analyzer definition.
// SearchAnalyzer search analyzer definition.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if updating this be mindful to write it like simple sentence so this page can be read
https://pkg.go.dev/go.mongodb.org/atlas@v0.8.0/mongodbatlas#SearchAnalyzer

gssbzn
gssbzn approved these changes Jun 24, 2021
View reviewed changes
Copy link
Collaborator

@gssbzn gssbzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM just be mindful on the godocs as they should be written as a sentence

themantissa
themantissa reviewed Jun 24, 2021
View reviewed changes
Copy link
Collaborator

@themantissa themantissa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

themantissa
themantissa approved these changes Jun 24, 2021
View reviewed changes
Copy link
Collaborator

@themantissa themantissa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, sorry hit comment first time!

@abner-dou abner-dou merged commit b506f92 into master Jun 29, 2021
@abner-dou abner-dou deleted the add_custom_seach_analyzer branch June 29, 2021 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gssbzn gssbzn gssbzn approved these changes

@themantissa themantissa themantissa approved these changes

@thetonymaster thetonymaster thetonymaster approved these changes

@coderGo93 coderGo93 Awaiting requested review from coderGo93

@foesa foesa Awaiting requested review from foesa

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@abner-dou @gssbzn @themantissa @thetonymaster