task: enable thelper and errorlint #225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gssbzn
commented
Jun 24, 2021
| @@ -169,24 +169,6 @@ type ListOptions struct { | |||
| ItemsPerPage int `url:"itemsPerPage,omitempty"` | |||
| } | |||
|
|
|||
| // ErrorResponse reports the error caused by an API request. | |||
| type ErrorResponse struct { | |||
There was a problem hiding this comment.
moved closer to the implementation of Error
gssbzn
commented
Jun 24, 2021
| @@ -222,7 +204,7 @@ func (resp *Response) CurrentPage() (int, error) { | |||
|
|
|||
| pageNum, err := strconv.Atoi(pageNumStr) | |||
| if err != nil { | |||
| return 0, fmt.Errorf("error getting current page: %s", err) | |||
| return 0, fmt.Errorf("error getting current page: %w", err) | |||
There was a problem hiding this comment.
w is a go1.13 wrapper for errors which allows error.Is to map wrapped errors
threebee
reviewed
Jun 24, 2021
Comment on lines
+63
to
+73
| - bodyclose # checks whether HTTP response body is closed successfully [fast: false, auto-fix: false] | ||
| - deadcode # Finds unused code [fast: false, auto-fix: false] | ||
| - depguard # Go linter that checks if package imports are in a list of acceptable packages [fast: false, auto-fix: false] | ||
| - dogsled # Checks assignments with too many blank identifiers (e.g. x, _, _, _, := f()) [fast: true, auto-fix: false] | ||
| - errcheck # Errcheck is a program for checking for unchecked errors in go programs. These unchecked errors can be critical bugs in some cases [fast: false, auto-fix: false] | ||
| - errorlint # errorlint is a linter for that can be used to find code that will cause problems with the error wrapping scheme introduced in Go 1.13. [fast: false, auto-fix: false] | ||
| - exhaustive # check exhaustiveness of enum switch statements [fast: false, auto-fix: false] | ||
| - exportloopref # checks for pointers to enclosing loop variables [fast: false, auto-fix: false] | ||
| - gochecknoinits # Checks that no init functions are present in Go code [fast: true, auto-fix: false] | ||
| - gocritic # Provides many diagnostics that check for bugs, performance and style issues. [fast: false, auto-fix: false] | ||
| - gocyclo # Computes and checks the cyclomatic complexity of functions [fast: true, auto-fix: false] |
There was a problem hiding this comment.
Thank you for adding the description for each linter!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Enables
thelper, this linter makes sure that test helper functions callt.HelperEnables
errorlint, making sure error handling follow go1.13 error handling best practices