Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Renamed AdvancedRegionSpec to AdvancedReplicationSpec #230

Merged
merged 3 commits into from Jun 30, 2021
Merged

Renamed AdvancedRegionSpec to AdvancedReplicationSpec #230

merged 3 commits into from Jun 30, 2021

Conversation

andreaangiolillo
Copy link
Collaborator

@andreaangiolillo andreaangiolillo commented Jun 30, 2021 •
edited

Description

Renamed AdvancedRegionSpec to AdvancedReplicationSpec and added missing json string for RegionConfigs

Type of change:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Required Checklist:

  • I have signed the MongoDB CLA
  • I have added tests that prove my fix is effective or that my feature works
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code

Further comments

@andreaangiolillo andreaangiolillo requested a review from a team as a code owner June 30, 2021 07:41
@andreaangiolillo andreaangiolillo requested review from threebee, gssbzn and a team and removed request for a team and threebee June 30, 2021 07:41
threebee
threebee previously approved these changes Jun 30, 2021
View reviewed changes
Copy link

@threebee threebee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gssbzn gssbzn added the breaking Pull requests that breaks backwards compatibility label Jun 30, 2021
gssbzn
gssbzn approved these changes Jun 30, 2021
View reviewed changes
Copy link
Collaborator

@gssbzn gssbzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andreaangiolillo andreaangiolillo merged commit 0935f2b into master Jun 30, 2021
@gssbzn gssbzn deleted the fixStructName branch September 14, 2021 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gssbzn gssbzn gssbzn approved these changes

@threebee threebee threebee left review comments

Assignees
No one assigned
Labels
breaking Pull requests that breaks backwards compatibility
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@andreaangiolillo @gssbzn @threebee