Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added missing comments and omitempty tags for the ProcessArgs struct #24

Merged
merged 2 commits into from Nov 5, 2019
Merged

Added missing comments and omitempty tags for the ProcessArgs struct #24

merged 2 commits into from Nov 5, 2019

Conversation

PacoDw
Copy link
Contributor

@PacoDw PacoDw commented Nov 5, 2019

  • Added missing comments
  • Added omitempty tags for the ProcessArgs struct

@PacoDw PacoDw changed the title chore: added missing comments and omitempty tag for ProcessArgs struct Added missing comments and omitempty tags for the ProcessArgs struct Nov 5, 2019
marinsalinas
marinsalinas previously approved these changes Nov 5, 2019
View reviewed changes
Copy link
Contributor

@marinsalinas marinsalinas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

themantissa
themantissa previously approved these changes Nov 5, 2019
View reviewed changes
Copy link
Collaborator

@themantissa themantissa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! See comments for clarification and suggested change.

mongodbatlas/clusters.go Outdated Show resolved Hide resolved
@PacoDw PacoDw dismissed stale reviews from themantissa and marinsalinas via ad73a34 November 5, 2019 22:22
@PacoDw PacoDw merged commit 2645edc into master Nov 5, 2019
@PacoDw PacoDw deleted the cluster_advanced_config branch November 5, 2019 23:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@themantissa themantissa themantissa approved these changes

@marinsalinas marinsalinas marinsalinas left review comments

@SpencerBrown SpencerBrown Awaiting requested review from SpencerBrown

@thetonymaster thetonymaster Awaiting requested review from thetonymaster

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@PacoDw @marinsalinas @themantissa