Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLOUDP-97443: add access tracking to the atlas go client #241

Merged
merged 2 commits into from Aug 16, 2021
Merged

CLOUDP-97443: add access tracking to the atlas go client #241

merged 2 commits into from Aug 16, 2021

Conversation

andreaangiolillo
Copy link
Collaborator

@andreaangiolillo andreaangiolillo commented Aug 16, 2021 •
edited

Description

add access tracking to the atlas go client

Type of change:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Required Checklist:

  • I have signed the MongoDB CLA
  • I have added tests that prove my fix is effective or that my feature works
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code

Further comments

@andreaangiolillo andreaangiolillo requested a review from a team as a code owner August 16, 2021 10:37
@andreaangiolillo andreaangiolillo requested review from gssbzn and fmenezes and removed request for a team August 16, 2021 10:37
gssbzn
gssbzn requested changes Aug 16, 2021
View reviewed changes
Copy link
Collaborator

@gssbzn gssbzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for this, just a couple of small nits, the docs comment is not blocking

mongodbatlas/access_tracking.go Outdated Show resolved Hide resolved
mongodbatlas/access_tracking.go Outdated Show resolved Hide resolved
mongodbatlas/access_tracking_test.go Outdated Show resolved Hide resolved
fmenezes
fmenezes approved these changes Aug 16, 2021
View reviewed changes
Copy link
Contributor

@fmenezes fmenezes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, make sure to address @gssbzn points

gssbzn
gssbzn approved these changes Aug 16, 2021
View reviewed changes
Copy link
Collaborator

@gssbzn gssbzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks for the fixes

@andreaangiolillo andreaangiolillo merged commit 52928af into master Aug 16, 2021
@gssbzn gssbzn deleted the CLOUDP-97443 branch September 14, 2021 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gssbzn gssbzn gssbzn approved these changes

@fmenezes fmenezes fmenezes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@andreaangiolillo @gssbzn @fmenezes