Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add support for creation of cloudgov only projects #243

Merged
merged 1 commit into from Aug 23, 2021
Merged

feat: add support for creation of cloudgov only projects #243

merged 1 commit into from Aug 23, 2021

Conversation

gssbzn
Copy link
Collaborator

@gssbzn gssbzn commented Aug 20, 2021

Description

Type of change:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Required Checklist:

  • I have added tests that prove my fix is effective or that my feature works
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code

@gssbzn gssbzn requested a review from a team as a code owner August 20, 2021 08:08
@gssbzn gssbzn requested review from threebee and removed request for a team August 20, 2021 08:08
gssbzn
gssbzn commented Aug 20, 2021
View reviewed changes
mongodbatlas/projects.go
Name string `json:"name,omitempty"`
ClusterCount int `json:"clusterCount,omitempty"`
Created string `json:"created,omitempty"`
RegionUsageRestrictions string `json:"regionUsageRestrictions,omitempty"` // RegionUsageRestrictions for cloud.mongodbgov.com, valid values are GOV_REGIONS_ONLY, COMMERCIAL_FEDRAMP_REGIONS_ONLY, NONE
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just added this field but the reformatting makes it look like a bigger change

@gssbzn gssbzn changed the title feat: add support to creation of cloudgov only projects feat: add support for creation of cloudgov only projects Aug 20, 2021
andreaangiolillo
andreaangiolillo approved these changes Aug 20, 2021
View reviewed changes
Copy link
Collaborator

@andreaangiolillo andreaangiolillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

colm-quinn
colm-quinn approved these changes Aug 20, 2021
View reviewed changes
Copy link
Collaborator

@colm-quinn colm-quinn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gssbzn
Copy link
Collaborator Author

gssbzn commented Aug 20, 2021

@themantissa you probably want a review here for terraform later on

themantissa
themantissa approved these changes Aug 20, 2021
View reviewed changes
Copy link
Collaborator

@themantissa themantissa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for this and for the tag! Did not know we'll need this for terraform so will add to the fedramp work for it.

@gssbzn gssbzn merged commit f55efb4 into master Aug 23, 2021
@gssbzn gssbzn deleted the cloudgov branch August 23, 2021 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@threebee threebee threebee approved these changes

@colm-quinn colm-quinn colm-quinn approved these changes

@themantissa themantissa themantissa approved these changes

@andreaangiolillo andreaangiolillo andreaangiolillo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@gssbzn @threebee @colm-quinn @themantissa @andreaangiolillo