Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLOUDP-98424: Add unit tests for atlas search #246

Merged
merged 1 commit into from Aug 30, 2021
Merged

CLOUDP-98424: Add unit tests for atlas search #246

merged 1 commit into from Aug 30, 2021

Conversation

fmenezes
Copy link
Contributor

Description

Add more unit tests for atlas search covering case where a field type would be an array/slice

Link to any related issue(s): CLOUDP-98424

Type of change:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Required Checklist:

  • I have signed the MongoDB CLA
  • I have added tests that prove my fix is effective or that my feature works
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code

Further comments

@fmenezes fmenezes requested a review from a team as a code owner August 30, 2021 11:26
@fmenezes fmenezes requested review from threebee and removed request for a team August 30, 2021 11:26
gssbzn
gssbzn approved these changes Aug 30, 2021
View reviewed changes
Copy link
Collaborator

@gssbzn gssbzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is just to confirm that the recent changes to the client should address mongodb/terraform-provider-mongodbatlas#545 cc @themantissa

@fmenezes fmenezes merged commit 378a8da into master Aug 30, 2021
@fmenezes fmenezes deleted the CLOUDP-98424_unit_tests branch August 30, 2021 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gssbzn gssbzn gssbzn approved these changes

@threebee threebee Awaiting requested review from threebee

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@fmenezes @gssbzn