Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add pagination to listing x509 users #294

Merged
merged 1 commit into from May 18, 2022
Merged

feat: add pagination to listing x509 users #294

merged 1 commit into from May 18, 2022

Conversation

gssbzn
Copy link
Collaborator

@gssbzn gssbzn commented May 17, 2022

Description

closes #293

Type of change:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Required Checklist:

  • I have added tests that prove my fix is effective or that my feature works
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code

Further comments

@gssbzn gssbzn requested a review from a team as a code owner May 17, 2022 09:09
@gssbzn gssbzn added the breaking Pull requests that breaks backwards compatibility label May 17, 2022
@gssbzn gssbzn requested a review from themantissa May 17, 2022 09:10
themantissa
themantissa approved these changes May 17, 2022
View reviewed changes
Copy link
Collaborator

@themantissa themantissa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, ticket created for Terraform. @gssbzn did you create one for the CLI (if needed)?
Thank you!!

@gssbzn
Copy link
Collaborator Author

gssbzn commented May 18, 2022

@gssbzn did you create one for the CLI (if needed)?

I'll create one

@gssbzn gssbzn merged commit 1080bb4 into master May 18, 2022
@gssbzn gssbzn deleted the add-pagination-x509 branch May 18, 2022 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tibulca tibulca tibulca approved these changes

@themantissa themantissa themantissa approved these changes

Assignees
No one assigned
Labels
breaking Pull requests that breaks backwards compatibility
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

X509AuthDBUsers.GetUserCertificates does not support pagination
3 participants
@gssbzn @tibulca @themantissa