Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLOUDP-110989: Capture Raw response body #297

Merged
merged 2 commits into from May 27, 2022
Merged

CLOUDP-110989: Capture Raw response body #297

merged 2 commits into from May 27, 2022

Conversation

fmenezes
Copy link
Contributor

@fmenezes fmenezes commented May 27, 2022 •
edited

Description

Please include a summary of the fix/feature/change, including any relevant motivation and context.

We are adding a WithRaw() option to allow copying body responses.

Link to any related issue(s):

Type of change:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Required Checklist:

  • I have signed the MongoDB CLA
  • I have added tests that prove my fix is effective or that my feature works
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code

Further comments

based on mongodb/go-client-mongodb-ops-manager#72

@fmenezes fmenezes marked this pull request as ready for review May 27, 2022 11:48
@fmenezes fmenezes requested a review from a team as a code owner May 27, 2022 11:48
gssbzn
gssbzn approved these changes May 27, 2022
View reviewed changes
Copy link
Collaborator

@gssbzn gssbzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fmenezes fmenezes merged commit 6256d9f into master May 27, 2022
@fmenezes fmenezes deleted the CLOUDP-110989 branch May 27, 2022 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gssbzn gssbzn gssbzn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@fmenezes @gssbzn