Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Auditing #30

Merged
merged 3 commits into from Dec 23, 2019
Merged

Auditing #30

merged 3 commits into from Dec 23, 2019

Conversation

PacoDw
Copy link
Contributor

@PacoDw PacoDw commented Dec 3, 2019

Added:

  • Auditing resource to handle the API calls
  • Auditing test cases

marinsalinas
marinsalinas previously approved these changes Dec 4, 2019
View reviewed changes
themantissa
themantissa previously approved these changes Dec 11, 2019
View reviewed changes
Copy link
Collaborator

@themantissa themantissa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor change in that Auditings should be Auditing. Also note that Create/Delete is basically setting the PATCH get to true/false.

mongodbatlas/mongodbatlas.go Outdated Show resolved Hide resolved
@PacoDw PacoDw dismissed stale reviews from themantissa and marinsalinas via 4009a82 December 12, 2019 15:53
themantissa
themantissa reviewed Dec 12, 2019
View reviewed changes
Copy link
Collaborator

@themantissa themantissa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just change the two file names and we are good! (auditings and auditings_test to auditing and auditing_test)

@PacoDw PacoDw force-pushed the auditing branch 2 times, most recently from 76e8bf8 to 8f16f04 Compare December 12, 2019 16:06
themantissa
themantissa previously approved these changes Dec 12, 2019
View reviewed changes
Copy link
Collaborator

@themantissa themantissa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done, thank you!

marinsalinas
marinsalinas previously approved these changes Dec 12, 2019
View reviewed changes
Copy link
Contributor

@marinsalinas marinsalinas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@marinsalinas
Copy link
Contributor

@PacoDw could you please solve the conflicts to be able to merge it and cut the new release?

@PacoDw PacoDw dismissed stale reviews from marinsalinas and themantissa via 4947a86 December 23, 2019 20:49
@marinsalinas marinsalinas merged commit d5ddbb6 into master Dec 23, 2019
@marinsalinas marinsalinas deleted the auditing branch December 23, 2019 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marinsalinas marinsalinas marinsalinas approved these changes

@themantissa themantissa themantissa left review comments

@shum shum Awaiting requested review from shum

@thetonymaster thetonymaster Awaiting requested review from thetonymaster

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@PacoDw @marinsalinas @themantissa