Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLOUDP-132967: add the ability to use yaml file for advance cluster #307

Merged
merged 1 commit into from
Aug 16, 2022

Conversation

andreaangiolillo
Copy link
Collaborator

@andreaangiolillo andreaangiolillo commented Aug 16, 2022

Description

Ticket: CLOUDP-132967

I have tested that my changes work as expected:

./bin/atlas cluster create test1 --file ~/cluster.yaml -o json                                  
{
  "backupEnabled": false,
  "biConnector": {
    "enabled": false,
    "readPreference": "secondary"
  },
  "clusterType": "REPLICASET",
  "connectionStrings": {},
  "diskSizeGB": 40,
  "encryptionAtRestProvider": "NONE",
  "groupId": "5e4e593f70dfbf1010295836",
  "id": "62fb443c882d5d628508c0ec",
  "labels": [
    {
      "key": "Infrastructure Tool",
      "value": "mongoCLI"
    }
  ],
  "mongoDBMajorVersion": "5.0",
  "mongoDBVersion": "5.0.10",
  "name": "test1",
  "paused": false,
  "pitEnabled": false,
  "stateName": "CREATING",
  "replicationSpecs": [
    {
      "numShards": 1,
      "id": "62fb443c882d5d628508c0e5",
      "zoneName": "Zone 1",
      "regionConfigs": [
        {
          "analyticsSpecs": {
            "diskIOPS": 3000,
            "ebsVolumeType": "STANDARD",
            "instanceSize": "M30",
            "nodeCount": 0
          },
          "electableSpecs": {
            "diskIOPS": 3000,
            "ebsVolumeType": "STANDARD",
            "instanceSize": "M30",
            "nodeCount": 1
          },
          "readOnlySpecs": {
            "diskIOPS": 3000,
            "ebsVolumeType": "STANDARD",
            "instanceSize": "M30",
            "nodeCount": 0
          },
          "autoScaling": {
            "diskGB": {
              "enabled": false
            },
            "compute": {
              "enabled": false,
              "scaleDownEnabled": false
            }
          },
          "priority": 7,
          "providerName": "AWS",
          "regionName": "US_EAST_1"
        },
        {
          "analyticsSpecs": {
            "diskIOPS": 3000,
            "ebsVolumeType": "STANDARD",
            "instanceSize": "M30",
            "nodeCount": 0
          },
          "electableSpecs": {
            "diskIOPS": 3000,
            "ebsVolumeType": "STANDARD",
            "instanceSize": "M30",
            "nodeCount": 1
          },
          "readOnlySpecs": {
            "diskIOPS": 3000,
            "ebsVolumeType": "STANDARD",
            "instanceSize": "M30",
            "nodeCount": 0
          },
          "autoScaling": {
            "diskGB": {
              "enabled": false
            },
            "compute": {
              "enabled": false,
              "scaleDownEnabled": false
            }
          },
          "priority": 6,
          "providerName": "AWS",
          "regionName": "US_WEST_1"
        },
        {
          "analyticsSpecs": {
            "diskIOPS": 3000,
            "ebsVolumeType": "STANDARD",
            "instanceSize": "M30",
            "nodeCount": 0
          },
          "electableSpecs": {
            "diskIOPS": 3000,
            "ebsVolumeType": "STANDARD",
            "instanceSize": "M30",
            "nodeCount": 1
          },
          "readOnlySpecs": {
            "diskIOPS": 3000,
            "ebsVolumeType": "STANDARD",
            "instanceSize": "M30",
            "nodeCount": 0
          },
          "autoScaling": {
            "diskGB": {
              "enabled": false
            },
            "compute": {
              "enabled": false,
              "scaleDownEnabled": false
            }
          },
          "priority": 5,
          "providerName": "AWS",
          "regionName": "EU_WEST_1"
        }
      ]
    }
  ],
  "createDate": "2022-08-16T07:16:12Z",
  "rootCertType": "ISRGROOTX1",
  "versionReleaseSystem": "LTS"
}

Type of change:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Required Checklist:

  • I have signed the MongoDB CLA
  • I have added tests that prove my fix is effective or that my feature works
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code

Further comments

@andreaangiolillo andreaangiolillo marked this pull request as ready for review August 16, 2022 07:17
@andreaangiolillo andreaangiolillo requested a review from a team as a code owner August 16, 2022 07:17
@andreaangiolillo andreaangiolillo requested review from gssbzn and removed request for a team August 16, 2022 07:17
Copy link

@blva blva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@andreaangiolillo andreaangiolillo merged commit 7bc68c5 into master Aug 16, 2022
andreaangiolillo added a commit that referenced this pull request Aug 16, 2022
andreaangiolillo added a commit that referenced this pull request Aug 16, 2022
andreaangiolillo added a commit that referenced this pull request Oct 12, 2022
@gssbzn gssbzn deleted the CLOUDP-132967 branch January 25, 2023 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants