Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add GET process #311

Merged
merged 1 commit into from
Sep 26, 2022
Merged

feat: add GET process #311

merged 1 commit into from
Sep 26, 2022

Conversation

gssbzn
Copy link
Collaborator

@gssbzn gssbzn commented Sep 26, 2022

Description

Add support for GETing a single process

Link to any related issue(s):

Type of change:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Required Checklist:

  • I have added tests that prove my fix is effective or that my feature works
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code

@gssbzn gssbzn requested a review from a team as a code owner September 26, 2022 12:41
@gssbzn gssbzn requested review from themantissa and removed request for a team September 26, 2022 12:41
andreaangiolillo
andreaangiolillo approved these changes Sep 26, 2022
View reviewed changes
Copy link
Collaborator

@andreaangiolillo andreaangiolillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

themantissa
themantissa approved these changes Sep 26, 2022
View reviewed changes
Copy link
Collaborator

@themantissa themantissa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Will let the team know as this could be useful in Terraform later.

@gssbzn gssbzn merged commit 7b3a0d1 into master Sep 26, 2022
@gssbzn gssbzn deleted the process-get branch September 26, 2022 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tibulca tibulca tibulca approved these changes

@themantissa themantissa themantissa approved these changes

@andreaangiolillo andreaangiolillo andreaangiolillo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@gssbzn @tibulca @themantissa @andreaangiolillo