Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Whitelist #35

Merged
merged 2 commits into from Jan 10, 2020
Merged

Whitelist #35

merged 2 commits into from Jan 10, 2020

Conversation

PacoDw
Copy link
Contributor

@PacoDw PacoDw commented Dec 17, 2019

  • Added AwsSecurityGroup attribute, updated comments and refactored code due to changes

Note: this PR is WIP until resolving the update entry point

@PacoDw PacoDw changed the title WIP: whitelist Whitelist Dec 23, 2019
themantissa
themantissa previously approved these changes Dec 30, 2019
View reviewed changes
Copy link
Collaborator

@themantissa themantissa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - please ensure at least one other person reviews (e.g. Chris or Marin)

@PacoDw PacoDw mentioned this pull request Jan 2, 2020
Closed
shum
shum previously approved these changes Jan 6, 2020
View reviewed changes
mongodbatlas/project_ip_whitelist.go Outdated Show resolved Hide resolved
@PacoDw @shum
Update mongodbatlas/project_ip_whitelist.go
ea051bc 
Co-Authored-By: Chris Shum <shum@users.noreply.github.com>
@PacoDw PacoDw dismissed stale reviews from shum and themantissa via ea051bc January 6, 2020 16:12
@PacoDw PacoDw requested a review from shum January 6, 2020 23:46
@PacoDw PacoDw merged commit d0530ef into master Jan 10, 2020
@PacoDw PacoDw deleted the whitelist branch January 10, 2020 21:52
@shum shum mentioned this pull request Jan 13, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shum shum shum approved these changes

@themantissa themantissa themantissa left review comments

@marinsalinas marinsalinas Awaiting requested review from marinsalinas

@thetonymaster thetonymaster Awaiting requested review from thetonymaster

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@PacoDw @shum @themantissa