Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Database Users #49

Merged
merged 3 commits into from Feb 4, 2020
Merged

Database Users #49

merged 3 commits into from Feb 4, 2020

Conversation

PacoDw
Copy link
Contributor

@PacoDw PacoDw commented Jan 29, 2020

Added:

  • The x509Type parameter was added into the DatabaseUser struct because it's necessary for the users created and when it pretends to use the x509 auth database users resource to configure the auth.
  • A test case was added to verify the request and response using the x509Type parameter.

themantissa
themantissa previously approved these changes Jan 30, 2020
View reviewed changes
Copy link
Collaborator

@themantissa themantissa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@PacoDw
chore: added databaseName as parameter to be able to choose between o…
ef0204b 
…r admin

chore: changed test case adding dabase name
@marinsalinas marinsalinas merged commit 65c6327 into master Feb 4, 2020
@marinsalinas marinsalinas deleted the databaseUsers branch February 4, 2020 00:57
@greut greut mentioned this pull request May 24, 2020
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marinsalinas marinsalinas marinsalinas approved these changes

@themantissa themantissa themantissa left review comments

@shum shum Awaiting requested review from shum

@thetonymaster thetonymaster Awaiting requested review from thetonymaster

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@PacoDw @marinsalinas @themantissa