Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

INTMDB-828: Add Schedule Parameter to Online Archive #502

Merged
merged 4 commits into from
Jun 23, 2023
Merged

INTMDB-828: Add Schedule Parameter to Online Archive #502

merged 4 commits into from
Jun 23, 2023

Conversation

andreaangiolillo
Copy link
Collaborator

@andreaangiolillo andreaangiolillo commented Jun 23, 2023 •
edited
Loading

Description

This PR adds Schedule param to the online archive. Doc: createOnlineArchive

INTMDB-828

Type of change:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Required Checklist:

  • I have signed the MongoDB CLA
  • I have added tests that prove my fix is effective or that my feature works
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code

Further comments

@andreaangiolillo andreaangiolillo requested a review from a team as a code owner June 23, 2023 12:40
fmenezes
fmenezes previously approved these changes Jun 23, 2023
View reviewed changes
gssbzn
gssbzn previously approved these changes Jun 23, 2023
View reviewed changes
Copy link
Collaborator

@gssbzn gssbzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

wtrocki
wtrocki previously approved these changes Jun 23, 2023
View reviewed changes
@andreaangiolillo andreaangiolillo dismissed stale reviews from wtrocki and gssbzn via 3aad209 June 23, 2023 14:43
gssbzn
gssbzn approved these changes Jun 23, 2023
View reviewed changes
Copy link
Collaborator

@gssbzn gssbzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andreaangiolillo andreaangiolillo merged commit 94c1f7f into master Jun 23, 2023
3 checks passed
@andreaangiolillo andreaangiolillo deleted the INTMDB-828 branch June 23, 2023 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gssbzn gssbzn gssbzn approved these changes

@wtrocki wtrocki wtrocki left review comments

@fmenezes fmenezes Awaiting requested review from fmenezes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@andreaangiolillo @gssbzn @wtrocki @fmenezes