Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

X509 auth db users #51

Merged
merged 3 commits into from Feb 4, 2020
Merged

X509 auth db users #51

merged 3 commits into from Feb 4, 2020

Conversation

PacoDw
Copy link
Contributor

@PacoDw PacoDw commented Jan 31, 2020

Added:

  • X509 to handle the API calls
  • X509 test cases

themantissa
themantissa previously approved these changes Feb 1, 2020
View reviewed changes
Copy link
Collaborator

@themantissa themantissa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

marinsalinas
marinsalinas previously approved these changes Feb 3, 2020
View reviewed changes
Copy link
Contributor

@marinsalinas marinsalinas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marinsalinas
Copy link
Contributor

Just solve the conflicts and we are ready to merge it.

@PacoDw PacoDw dismissed stale reviews from marinsalinas and themantissa via 754d374 February 4, 2020 15:44
@marinsalinas marinsalinas merged commit a7bb5eb into master Feb 4, 2020
@PacoDw PacoDw deleted the x509AuthDBUsers branch February 4, 2020 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marinsalinas marinsalinas marinsalinas approved these changes

@shum shum Awaiting requested review from shum

@thetonymaster thetonymaster Awaiting requested review from thetonymaster

@themantissa themantissa Awaiting requested review from themantissa

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@PacoDw @marinsalinas @themantissa