Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add notifierId parameter in alert configuration notifications #516

Merged
merged 1 commit into from
Oct 11, 2023
Merged

feat: add notifierId parameter in alert configuration notifications #516

merged 1 commit into from
Oct 11, 2023

Conversation

AgustinBettati
Copy link
Member

Description

Ticket: INTMDB-981

Type of change:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Required Checklist:

  • I have signed the MongoDB CLA
  • I have added tests that prove my fix is effective or that my feature works
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code

Further comments

@AgustinBettati AgustinBettati requested a review from a team as a code owner October 9, 2023 15:05
@AgustinBettati AgustinBettati mentioned this pull request Oct 9, 2023
Merged
11 tasks
wtrocki
wtrocki approved these changes Oct 9, 2023
View reviewed changes
Copy link
Member

@wtrocki wtrocki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@wtrocki
Copy link
Member

wtrocki commented Oct 9, 2023

@AgustinBettati Would you like to perform release of the SDK?

@AgustinBettati
Copy link
Member Author

Will follow up with release PR.

@AgustinBettati AgustinBettati merged commit bca25ca into master Oct 11, 2023
3 checks passed
@AgustinBettati AgustinBettati deleted the INTMDB-981 branch October 11, 2023 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wtrocki wtrocki wtrocki approved these changes

@andreaangiolillo andreaangiolillo andreaangiolillo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@AgustinBettati @wtrocki @andreaangiolillo