Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLOUDP-58633: Add Restore Jobs support to atlas client #62

Merged
merged 5 commits into from Mar 12, 2020
Merged

CLOUDP-58633: Add Restore Jobs support to atlas client #62

merged 5 commits into from Mar 12, 2020

Conversation

andreaangiolillo
Copy link
Collaborator

No description provided.

gssbzn
gssbzn reviewed Mar 10, 2020
View reviewed changes
Copy link
Collaborator

@gssbzn gssbzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but let's test this before approving

gssbzn
gssbzn requested changes Mar 10, 2020
View reviewed changes
Copy link
Collaborator

@gssbzn gssbzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We missed a rename :(

mongodbatlas/mongodbatlas.go Outdated Show resolved Hide resolved
gssbzn
gssbzn previously approved these changes Mar 11, 2020
View reviewed changes
Copy link
Collaborator

@gssbzn gssbzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, ready for review on your side @themantissa

@gssbzn gssbzn requested a review from themantissa March 11, 2020 08:54
themantissa
themantissa previously approved these changes Mar 11, 2020
View reviewed changes
Copy link
Collaborator

@themantissa themantissa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - will add Paco/Marin next for when it's in their queue. Note for others - CloudFormation/Terraform will not be supporting continuous backups but cloud provider backup. thx!

PacoDw
PacoDw previously approved these changes Mar 12, 2020
View reviewed changes
Copy link
Contributor

@PacoDw PacoDw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT! just check the pending comments , but all is nice

gssbzn
gssbzn approved these changes Mar 12, 2020
View reviewed changes
Copy link
Collaborator

@gssbzn gssbzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, formality stamp after merging from master and solving a conflict

@andreaangiolillo andreaangiolillo merged commit 8894c1f into master Mar 12, 2020
@gssbzn gssbzn deleted the CLOUDP-58633 branch March 12, 2020 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gssbzn gssbzn gssbzn approved these changes

@themantissa themantissa themantissa left review comments

@PacoDw PacoDw PacoDw left review comments

@marinsalinas marinsalinas Awaiting requested review from marinsalinas

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@andreaangiolillo @gssbzn @themantissa @PacoDw