Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLOUDP-57848: Implement events resource in the atlas go client #72

Merged
merged 2 commits into from Apr 2, 2020
Merged

CLOUDP-57848: Implement events resource in the atlas go client #72

merged 2 commits into from Apr 2, 2020

Conversation

andreaangiolillo
Copy link
Collaborator

CLOUDP-57848

  • I have signed the MongoDB CLA
  • I have added tests that prove my fix is effective or that my feature works
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code
  • I have tested my code using cloud-dev env.

@andreaangiolillo andreaangiolillo mentioned this pull request Mar 27, 2020
Merged
4 tasks
gssbzn
gssbzn previously approved these changes Mar 27, 2020
View reviewed changes
Copy link
Collaborator

@gssbzn gssbzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, @themantissa ready for you, cheers

mongodbatlas/events.go
}

// EventListOptions specifies the optional parameters to the Event List methods.
type EventListOptions struct {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@gssbzn gssbzn requested a review from themantissa March 27, 2020 15:43
themantissa
themantissa previously approved these changes Mar 30, 2020
View reviewed changes
Copy link
Collaborator

@themantissa themantissa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Will add the DoU devs for final PR

@andreaangiolillo andreaangiolillo mentioned this pull request Apr 2, 2020
Merged
4 tasks
PacoDw
PacoDw previously approved these changes Apr 2, 2020
View reviewed changes
Copy link
Contributor

@PacoDw PacoDw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT! Thanks

marinsalinas
marinsalinas previously approved these changes Apr 2, 2020
View reviewed changes
Copy link
Contributor

@marinsalinas marinsalinas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just plz resolve this merge conflicts otherwise we are ready to merge it.

@gssbzn gssbzn dismissed stale reviews from marinsalinas, PacoDw, themantissa, and themself via c6e9ea7 April 2, 2020 14:32
@andreaangiolillo andreaangiolillo merged commit b2e23a1 into master Apr 2, 2020
@gssbzn gssbzn deleted the CLOUDP-57848 branch April 2, 2020 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marinsalinas marinsalinas marinsalinas approved these changes

@themantissa themantissa themantissa left review comments

@PacoDw PacoDw PacoDw left review comments

@coderGo93 coderGo93 Awaiting requested review from coderGo93

@gssbzn gssbzn Awaiting requested review from gssbzn

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@andreaangiolillo @gssbzn @marinsalinas @themantissa @PacoDw