Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLOUDP-60177: Implement Get Measurements of a Disk for a MongoDB Process, Atlas #78

Merged
merged 4 commits into from
Apr 8, 2020

Conversation

andreaangiolillo
Copy link
Collaborator

CLOUDP-60177

Response from the API call:


{
	"end": "2020-04-06T17:19:48Z",
	"granularity": "PT1M",
	"groupId": "5e4e593f70dfbf1010295836",
	"hostId": "cluster0-shard-00-00-ajlj3.mongodb-dev.net:27017",
	"links": [
		{
			"rel": "self",
			"href": "https://cloud-dev.mongodb.com/api/atlas/v1.0/groups/5e4e593f70dfbf1010295836/processes/cluster0-shard-00-00-ajlj3.mongodb-dev.net:27017/disks/data/measurements?ListOptions=\u0026granularity=PT1M\u0026period=PT1M"
		},
		{
			"rel": "http://mms.mongodb.com/host",
			"href": "https://cloud-dev.mongodb.com/api/atlas/v1.0/groups/5e4e593f70dfbf1010295836/processes/cluster0-shard-00-00-ajlj3.mongodb-dev.net:27017"
		}
	],
	"measurements": [
		{
			"dataPoints": [
				{
					"timestamp": "2020-04-06T17:19:48Z",
					"value": null
				}
			],
			"name": "DISK_PARTITION_IOPS_READ",
			"units": "SCALAR_PER_SECOND"
		},
		{
			"dataPoints": [
				{
					"timestamp": "2020-04-06T17:19:48Z",
					"value": null
				}
			],
			"name": "DISK_PARTITION_IOPS_WRITE",
			"units": "SCALAR_PER_SECOND"
		},
		{
			"dataPoints": [
				{
					"timestamp": "2020-04-06T17:19:48Z",
					"value": null
				}
			],
			"name": "DISK_PARTITION_IOPS_TOTAL",
			"units": "SCALAR_PER_SECOND"
		},
		{
			"dataPoints": [
				{
					"timestamp": "2020-04-06T17:19:48Z",
					"value": null
				}
			],
			"name": "DISK_PARTITION_UTILIZATION",
			"units": "PERCENT"
		},
		{
			"dataPoints": [
				{
					"timestamp": "2020-04-06T17:19:48Z",
					"value": null
				}
			],
			"name": "DISK_PARTITION_LATENCY_READ",
			"units": "MILLISECONDS"
		},
		{
			"dataPoints": [
				{
					"timestamp": "2020-04-06T17:19:48Z",
					"value": null
				}
			],
			"name": "DISK_PARTITION_LATENCY_WRITE",
			"units": "MILLISECONDS"
		},
		{
			"dataPoints": [
				{
					"timestamp": "2020-04-06T17:19:48Z",
					"value": 9087066000
				}
			],
			"name": "DISK_PARTITION_SPACE_FREE",
			"units": "BYTES"
		},
		{
			"dataPoints": [
				{
					"timestamp": "2020-04-06T17:19:48Z",
					"value": 1639866400
				}
			],
			"name": "DISK_PARTITION_SPACE_USED",
			"units": "BYTES"
		},
		{
			"dataPoints": [
				{
					"timestamp": "2020-04-06T17:19:48Z",
					"value": 84.71262
				}
			],
			"name": "DISK_PARTITION_SPACE_PERCENT_FREE",
			"units": "PERCENT"
		},
		{
			"dataPoints": [
				{
					"timestamp": "2020-04-06T17:19:48Z",
					"value": 15.2873745
				}
			],
			"name": "DISK_PARTITION_SPACE_PERCENT_USED",
			"units": "PERCENT"
		}
	],
	"processId": "cluster0-shard-00-00-ajlj3.mongodb-dev.net:27017",
	"start": "2020-04-06T17:19:48Z",
	"partitionName": "nvme1n1"
}

Copy link
Collaborator

@gssbzn gssbzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

couple of nits but looking good

mongodbatlas/process_disk_measurements_test.go Outdated Show resolved Hide resolved
mongodbatlas/process_disk_measurements.go Outdated Show resolved Hide resolved

// ProcessDiskMeasurements represents a MongoDB Process Disk Measurements.
type ProcessDiskMeasurements struct {
*ProcessMeasurements
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clever

gssbzn
gssbzn previously approved these changes Apr 7, 2020
Copy link
Collaborator

@gssbzn gssbzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, ready for you @themantissa

@themantissa themantissa self-requested a review April 7, 2020 22:39
themantissa
themantissa previously approved these changes Apr 7, 2020
Copy link
Collaborator

@themantissa themantissa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, LGTM - Will add DoU team.

@themantissa
Copy link
Collaborator

@marinsalinas @PacoDw @coderGo93 - can one of you give a sanity check review?

PacoDw
PacoDw previously approved these changes Apr 8, 2020
Copy link
Contributor

@PacoDw PacoDw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gssbzn gssbzn dismissed stale reviews from PacoDw, themantissa, and themself via bae39d7 April 8, 2020 13:55
@gssbzn gssbzn merged commit 923d69b into master Apr 8, 2020
@gssbzn gssbzn deleted the CLOUDP-60177 branch April 8, 2020 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants