Add database measurements Endpoint #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@themantissa ready for your review |
|
@PacoDw @marinsalinas @coderGo93 this one is just a sanity check PR, shouldn't impact any downstream work for Terraform/Vault/CFN. |
gssbzn
dismissed stale reviews from themantissa and andreaangiolillo
via
45e9df3
PacoDw
reviewed
Apr 13, 2020
mongodbatlas/mongodbatlas.go
Outdated
Comment on lines
24
to
25
| mediaType = "application/json" | ||
| gzipMediaType = "application/gzip" |
There was a problem hiding this comment.
Nice! maybe we should rename mediaType tojsonMediaType, what do you think?
PacoDw
previously approved these changes
Apr 13, 2020
Co-Authored-By: Andrea Angiolillo <andrea.angiolillo@mongodb.com>
Co-Authored-By: Andrea Angiolillo <andrea.angiolillo@mongodb.com>
gssbzn
force-pushed
the
database-measurements
branch
from
45e9df3
to
cebb5eb
Compare
PacoDw
approved these changes
Apr 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.