Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Change backup options to interfaces #135

Merged
merged 1 commit into from
Jan 26, 2022
Merged

fix: Change backup options to interfaces #135

merged 1 commit into from
Jan 26, 2022

Conversation

gssbzn
Copy link
Collaborator

@gssbzn gssbzn commented Jan 26, 2022

Proposed changes

This properties are not string and failing to be deserialized, moving to interface for now

Checklist

  • I have added tests that prove my fix is effective or that my feature works
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code

@gssbzn gssbzn requested a review from a team as a code owner January 26, 2022 11:09
@gssbzn gssbzn requested review from johansteyn and removed request for a team January 26, 2022 11:09
andreaangiolillo
andreaangiolillo approved these changes Jan 26, 2022
View reviewed changes
Copy link
Collaborator

@andreaangiolillo andreaangiolillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gssbzn gssbzn merged commit d001b5c into master Jan 26, 2022
@gssbzn gssbzn deleted the fix-backup-options branch January 26, 2022 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andreaangiolillo andreaangiolillo andreaangiolillo approved these changes

@johansteyn johansteyn Awaiting requested review from johansteyn johansteyn is a code owner automatically assigned from mongodb/apix

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@gssbzn @andreaangiolillo