task: update golangci-lint to latest #161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gssbzn
commented
Sep 28, 2022
| @@ -142,3 +142,10 @@ linters: | |||
| # - wastedassign # wastedassign finds wasted assignment statements. [fast: false, auto-fix: false] | |||
| # - wrapcheck # Checks that errors returned from external packages are wrapped [fast: false, auto-fix: false] | |||
| # - wsl # Whitespace Linter - Forces you to use empty lines! [fast: true, auto-fix: false] | |||
|
|
|||
| run: | |||
| go: '1.17' | |||
There was a problem hiding this comment.
ping to prevent generic warnings, we don't use generics
gssbzn
commented
Sep 28, 2022
| for i := 0; i < len(intermediateDigest); i++ { | ||
| result[i] = intermediateDigest[i] | ||
| } | ||
| copy(result, intermediateDigest) |
gssbzn
commented
Sep 28, 2022
| @@ -74,7 +74,6 @@ func TestClusters_Get(t *testing.T) { | |||
| client, mux, teardown := setup() | |||
| defer teardown() | |||
|
|
|||
| clusterID := "533d7d4730040be257defe88" | |||
There was a problem hiding this comment.
driveby, already defined
gssbzn
commented
Sep 28, 2022
| @@ -15,7 +15,7 @@ | |||
| /* | |||
| Package opsmngr provides a client for using the MongoDB Ops Manager and Cloud Manager API. | |||
|
|
|||
| Usage | |||
There was a problem hiding this comment.
linter complains since the gofmt changed in 1.19
tibulca
approved these changes
Sep 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Updating to latest lint version and needed fixes preventing me from committing other changes
Checklist
make fmtand formatted my code