Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove tslib usage and fix Long method alias #415

Merged
merged 3 commits into from
Dec 1, 2020
Merged

Conversation

nbbeeken
Copy link
Contributor

@nbbeeken nbbeeken commented Dec 1, 2020

fix: remove tslib usage and fix Long method alias

@nbbeeken nbbeeken requested review from mbroadst, emadum and kmahar and removed request for mbroadst December 1, 2020 20:02
Copy link
Contributor

@kmahar kmahar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one question but LGTM

@@ -21,7 +21,40 @@ import { BSONSymbol } from './symbol';
import { Timestamp } from './timestamp';
export { BinaryExtended, BinaryExtendedLegacy, BinarySequence } from './binary';
export { CodeExtended } from './code';
export * from './constants';
export {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why did this change?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is what introduces the tslib import, exportStar needs some actions to replicate for commonjs.

https://github.com/microsoft/tslib/blob/fcba93d415a6d84914916769ba17871902dd4598/tslib.es6.js#L114

@nbbeeken nbbeeken merged commit 2d9a8e6 into master Dec 1, 2020
@nbbeeken nbbeeken deleted the fix/tslib-usage branch December 1, 2020 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants