Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(NODE-3282): BSONRegExp options not alphabetized #441

Merged
merged 2 commits into from Jun 8, 2021
Merged

fix(NODE-3282): BSONRegExp options not alphabetized #441

merged 2 commits into from Jun 8, 2021

Conversation

andymina
Copy link
Contributor

@andymina andymina commented Jun 7, 2021

Description

  • Fixed alphabetizing the options.
  • Corrected the degenerate BSON spec test to test deserializer

@andymina andymina requested a review from emadum June 7, 2021 17:28
emadum
emadum suggested changes Jun 7, 2021
View reviewed changes
Copy link
Contributor

@emadum emadum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice work! One request - I don't think a new file is necessary for this one new test, could you put it in test/node/bson_test.js instead?

@emadum emadum requested review from a team, durran, W-A-James, nbbeeken and dariakp and removed request for a team, durran and W-A-James June 8, 2021 15:29
@andymina andymina requested a review from emadum June 8, 2021 19:51
@andymina andymina merged commit 18c3512 into master Jun 8, 2021
@andymina andymina deleted the NODE-3282/bson-regex branch June 8, 2021 21:20
@github-actions github-actions bot mentioned this pull request May 7, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emadum emadum emadum approved these changes

@dariakp dariakp dariakp approved these changes

@nbbeeken nbbeeken Awaiting requested review from nbbeeken

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@andymina @emadum @dariakp