fix(NODE-4960): UUID validation too strict #572
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nbbeeken
changed the title
src/binary.ts
Outdated
| @@ -485,6 +471,26 @@ export class UUID extends Binary { | |||
| return new UUID(ByteUtils.fromBase64(base64)); | |||
| } | |||
|
|
|||
| /** @internal */ | |||
| static uuidBytesFromString(representation: string) { | |||
There was a problem hiding this comment.
The naming is redundant here since it's a static UUID method
Suggested change
| static uuidBytesFromString(representation: string) { | |
| static bytesFromString(representation: string) { |
baileympearson
requested changes
Apr 21, 2023
|
|
||
| /** | ||
| * A class representation of the BSON UUID type. | ||
| * @public | ||
| */ | ||
| export class UUID extends Binary { | ||
| static cacheHexString: boolean; |
There was a problem hiding this comment.
Can this safely be removed? It's a public property
There was a problem hiding this comment.
Good catch, added it back and filed follow ups, we can deprecate it in the subtask I made and remove in v6
addaleax
requested changes
Apr 24, 2023
addaleax
previously approved these changes
Apr 24, 2023
5 tasks
baileympearson
approved these changes
Apr 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What is changing?
Our UUID class generates UUID v4 instances but it does not need to contain only v4. We lift the validation on the version byte entirely here to support all uuid versions and "empty" uuid.
Is there new documentation needed for these changes?
What is the motivation for this change?
Double check the following
npm run lintscripttype(NODE-xxxx)[!]: descriptionfeat(NODE-1234)!: rewriting everything in coffeescript