feat(NODE-5506): add Binary subtype sensitive #657
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aditi-khare-mongoDB
changed the title
nbbeeken
requested changes
Mar 11, 2024
There was a problem hiding this comment.
Pretty much lgtm, just a few more bits: Can we also add to the static constants we have on the Binary class? and tests that match what we did with the last new constant?
Also "See release highlights." but there are none, this is a feat so it should have something, I'd say nothing more than the new constant on the Binary class and what it refers to.
nbbeeken
added
the
Primary Review
git push
nbbeeken
requested changes
Mar 11, 2024
nbbeeken
changed the title
Co-authored-by: Neal Beeken <neal.beeken@mongodb.com>
nbbeeken
approved these changes
Mar 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
New
BSON.Binarysubtype 0x08sensitiveis introduced.What is changing?
See release highlights.
Is there new documentation needed for these changes?
No, internal changes only.
What is the motivation for this change?
Release Highlight
Add
SUBTYPE_SENSITIVEonBinaryclassWhen a BSON.Binary object is of 'sensitive' subtype, the object's subtype will equal
0x08.Double check the following
npm run check:lintscripttype(NODE-xxxx)[!]: descriptionfeat(NODE-1234)!: rewriting everything in coffeescript