Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(NODE-6059): clean up experimental APIs #665

Merged
merged 4 commits into from Apr 1, 2024
Merged

Conversation

nbbeeken
Copy link
Contributor

Description

What is changing?

  • Remove parseToStructure
  • Fix NumberUtils and ByteUtils this type issue
  • Move BSONOffsetError to top-level export along with other errors
  • Move getSize to NumberUtils
    • Add wrapper to support bson specific message and error type
Is there new documentation needed for these changes?

No

What is the motivation for this change?

A portion of these APIs are not going to be used, and there was some TS convenience issues.

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@W-A-James W-A-James self-assigned this Apr 1, 2024
@W-A-James W-A-James added the Primary Review In Review with primary reviewer, not yet ready for team's eyes label Apr 1, 2024
W-A-James
W-A-James previously approved these changes Apr 1, 2024
@W-A-James W-A-James added Team Review Needs review from team and removed Primary Review In Review with primary reviewer, not yet ready for team's eyes labels Apr 1, 2024
@W-A-James W-A-James merged commit 3289184 into main Apr 1, 2024
5 checks passed
@W-A-James W-A-James deleted the NODE-6059-cleanup branch April 1, 2024 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team Review Needs review from team
Projects
None yet
3 participants