fix(NODE-6102): Double.fromString prohibiting '+' character and prohibiting exponential notation #674
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aditi-khare-mongoDB
changed the title
Comment on lines
+52
to
+54
| if (value === 'NaN') return new Double(NaN); | ||
| if (value === 'Infinity') return new Double(Infinity); | ||
| if (value === '-Infinity') return new Double(-Infinity); |
There was a problem hiding this comment.
refactored these cases to have clearer notation.
…sitive (/i flag was being finicky so just hard coded it
baileympearson
approved these changes
Apr 19, 2024
nbbeeken
added
the
Primary Review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Double.fromStringshould allow'+'character in its input.Double.fromStringshould allow exponential format.What is changing?
See above. and also refactor some of the function to make the error messages more clear and the code's logic clearer as well.
Is there new documentation needed for these changes?
No, bug fix on an unreleased feature.
What is the motivation for this change?
See description.
Release Highlight
Double check the following
npm run check:lintscripttype(NODE-xxxx)[!]: descriptionfeat(NODE-1234)!: rewriting everything in coffeescript