Revert column type detection, as the number of arguments is unreliable

mongodb · Oct 19, 2023 · 0317ba4 · 0317ba4
1 parent 5a7e108
commit 0317ba4
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/src/Query/Builder.php b/src/Query/Builder.php
@@ -984,8 +984,8 @@ public function where($column, $operator = null, $value = null, $boolean = 'and'
             throw new ArgumentCountError(sprintf('Too few arguments to function %s(%s), 1 passed and at least 2 expected when the 1st is not an array or a callable', __METHOD__, var_export($column, true)));
         }
 
-        if (! is_int($column) && ! is_string($column)) {
-            throw new InvalidArgumentException(sprintf('First argument of %s must be a column name as "string". Got "%s"', __METHOD__, get_debug_type($column)));
+        if (is_float($column) || is_bool($column) || is_null($column)) {
+            throw new InvalidArgumentException(sprintf('First argument of %s must be a field path as "string". Got "%s"', __METHOD__, get_debug_type($column)));
         }
 
         return parent::where(...$params);

diff --git a/tests/Query/BuilderTest.php b/tests/Query/BuilderTest.php
@@ -1222,7 +1222,7 @@ public static function provideExceptions(): iterable
 
         yield 'where invalid column type' => [
             InvalidArgumentException::class,
-            'First argument of MongoDB\Laravel\Query\Builder::where must be a column name as "string". Got "float"',
+            'First argument of MongoDB\Laravel\Query\Builder::where must be a field path as "string". Got "float"',
             fn (Builder $builder) => $builder->where(2.3, '>', 1),
         ];
     }