Added functionality to service provider #18
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a method which registers the mongodb connection as the database presence verifier for use with laravel Validation
|
Maybe we should add this to a separate service provider so that we can make this optional? This pull request currently breaks the code because Illuminate\Validation is not required in the composer.json. |
|
Yes, that's probably a good idea, and I thought about it a bit some earlier. The only thing I wonder is whether one service provider should depend on another. As for the break, the latest commit in the pull should have the proper dependency. That is strange. |
|
I found a way to extend the original database manager instead of registering a new database manager. This pull request is probably no longer needed since it is now using app['db'] and not app['mongodb'] anymore. |
|
Thanks! |
Closed
This was referenced Nov 26, 2018
alcaeus
pushed a commit
to alcaeus/laravel-mongodb
that referenced
this pull request
Aug 16, 2023
…ountDocuments (mongodb#18) https://www.mongodb.com/docs/php-library/current/reference/method/MongoDBCollection-count/ Fix pass options to countDocuments for transaction session
alcaeus
pushed a commit
that referenced
this pull request
Aug 22, 2023
…ountDocuments (#18) https://www.mongodb.com/docs/php-library/current/reference/method/MongoDBCollection-count/ Fix pass options to countDocuments for transaction session
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a method which registers the mongodb connection as the database
presence verifier for use with laravel Validation