Fix dropIndex for compound indexes with sorting order #1885
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mauri870 add description please |
|
Description updated @Smolevich |
|
@mauri870 tests failed, check please |
mauri870
force-pushed
the
drop-compound-index
branch
4 times, most recently
from
87b6e2d
to
296dfd4
Compare
|
@Smolevich Can you take a look at the failing test? Can't find the cause of the error. |
See
|
mauri870
force-pushed
the
drop-compound-index
branch
4 times, most recently
from
1cacd52
to
b13bc18
Compare
|
@Smolevich All tests passing |
mauri870
force-pushed
the
drop-compound-index
branch
from
b13bc18
to
be0dabd
Compare
mauri870
force-pushed
the
drop-compound-index
branch
from
be0dabd
to
ca0f710
Compare
Giacomo92
approved these changes
Feb 5, 2020
|
Can you merge actual master, please? @mauri870 |
Smolevich
approved these changes
Feb 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's not possible to drop an index with a descending sorting order, because the library assumes an ascending order. If no order is given to the field, the default order is used.