Remove Query\Builder::__constructor overload
#2570
Conversation
Codecov ReportPatch coverage:
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## master #2570 +/- ##
============================================
- Coverage 90.58% 90.56% -0.03%
+ Complexity 748 747 -1
============================================
Files 34 34
Lines 1785 1781 -4
============================================
- Hits 1617 1613 -4
Misses 168 168
☔ View full report in Codecov by Sentry. |
GromNaN
force-pushed
the
query-builder-constructor
branch
from
ad01850
to
f38f5c7
Compare
src/Query/Builder.php
Outdated
| */ | ||
| public function newQuery() | ||
| { | ||
| return new self($this->connection, $this->processor); | ||
| return new self($this->connection, $this->grammar, $this->processor); |
There was a problem hiding this comment.
Identical to parent method, but provide a more specific @return type.
| @@ -164,10 +164,10 @@ public function chunkById($count, callable $callback, $column = '_id', $alias = | |||
| /** | |||
| * @inheritdoc | |||
| */ | |||
| public function raw($expression = null) | |||
| public function raw($value = null) | |||
There was a problem hiding this comment.
Get the argument name from the parent method.
There was a problem hiding this comment.
LGTM if my assumptions in the previous questions in GromNaN/laravel-mongodb#26 were correct.
GromNaN
force-pushed
the
query-builder-constructor
branch
from
f38f5c7
to
c801f2c
Compare
|
@GromNaN LGTM. Can you rebase to resolve the conflicts in the changelog? |
GromNaN
force-pushed
the
query-builder-constructor
branch
from
c801f2c
to
613f838
Compare
GromNaN
force-pushed
the
query-builder-constructor
branch
from
613f838
to
1cec6e8
Compare
|
Rebased. |
The constructor don't need to be overloaded to set the default grammar. It is read from the connection by default.
https://github.com/laravel/framework/blob/10.x/src/Illuminate/Database/Query/Builder.php#L246