Support delete one document with the query builder #2591
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmikola
reviewed
Aug 31, 2023
| @@ -703,7 +703,14 @@ public function delete($id = null) | |||
| $wheres = $this->compileWheres(); | |||
| $options = $this->inheritConnectionOptions(); | |||
|
|
|||
| $result = $this->collection->deleteMany($wheres, $options); | |||
| if ($this->limit) { | |||
| if ($this->limit !== 1) { | |||
There was a problem hiding this comment.
Should limit === 0 be supported? Or would Eloquent expect that to be a NOP?
I suppose the notion of limit: 0 meaning "delete all" is an implementation detail of MongoDB's delete command and not a general concept, so I'm fine with not supporting that.
I do wonder if we should have a separate exception message if 0 is specified that advises users to specify null instead (or not call limit() at all), as this message might confuse a user with more experience with MongoDB than Eloquent.
There was a problem hiding this comment.
You're absolutely right. I've also banned 0.
jmikola
approved these changes
Sep 1, 2023
enkhjargal
approved these changes
Sep 1, 2023
|
Related issue: #2597 |
GromNaN
added a commit
that referenced
this pull request
Sep 5, 2023
Custom implementation of MassPrunable is required to prevent using the limit. #2591 added an exception when limited is used because MongoDB Delete operation doesn't support it. - MassPrunable::pruneAll() is called by the command model:prune. - Using the parent trait is required because it's used to detect prunable models. - Prunable feature was introducted in Laravel 8.x by laravel/framework#37889. Users have to be aware that MassPrunable can break relationships as it doesn't call model methods to remove links.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #2502
MongoDB PHP Library supports deleting one or all documents only. So we cannot accept other limits than
null(unlimited) or1.